-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace subscan with kilt-indexer #743
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because behaviour different than on playground. This reverts commit a02a990.
arty-name
reviewed
Aug 14, 2024
arty-name
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is generally in a good shape now, only tests need to be fixed
kilted-andres
force-pushed
the
xw/use_indexer
branch
from
August 14, 2024 11:52
a1d9046
to
0a721f9
Compare
kilted-andres
force-pushed
the
xw/use_indexer
branch
from
August 14, 2024 11:54
0a721f9
to
ec608af
Compare
kilted-andres
added a commit
that referenced
this pull request
Sep 11, 2024
During a regression test after [ctypehub/pull/743](#743), it was found that the "Registration Block" component was showing a broken link after creating a cType from inside the app. This was because the block was still not available and the link required the block number. Now: - The component will direct to the polkadot.js explorer (without querying a specific block) when block number is undefined. Reverted: - ~When submitting a cType creation transaction, it will be awaited until it is _InBlock_.~ ## Other fix: Handle cTypes without a title.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes KILTProtocol/ticket#3554