Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace subscan with kilt-indexer #743

Merged
merged 107 commits into from
Aug 14, 2024
Merged

feat: replace subscan with kilt-indexer #743

merged 107 commits into from
Aug 14, 2024

Conversation

kilted-andres
Copy link
Contributor

@kilted-andres kilted-andres commented Jul 30, 2024

fixes KILTProtocol/ticket#3554

  • Replace Subscan-Logic with the KILT Indexer.
  • Remove Attestations from the Database.
  • Remove the "extrinsicHash" property from the cType tables.
  • Link to cType creation block on polkadot.js instead of extrinsic on subscan.
  • Hide hidden cTypes during tags search.

Copy link
Collaborator

@arty-name arty-name left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is generally in a good shape now, only tests need to be fixed

@kilted-andres kilted-andres merged commit db2ccad into main Aug 14, 2024
1 check passed
@kilted-andres kilted-andres deleted the xw/use_indexer branch August 14, 2024 12:56
kilted-andres added a commit that referenced this pull request Sep 11, 2024
During a regression test after [ctypehub/pull/743](#743), it was found that the "Registration Block" component was showing a broken link after creating a cType from inside the app. This was because the block was still not available and the link required the block number.

Now: 

- The component will direct to the polkadot.js explorer (without querying a specific block) when block number is undefined. 
Reverted: - ~When submitting a cType creation transaction, it will be awaited until it is _InBlock_.~

## Other fix: 
Handle cTypes without a title.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants